Open
Conversation
18 tasks
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
dervoeti
reviewed
Mar 2, 2026
Member
dervoeti
left a comment
dervoeti
left a comment
There was a problem hiding this comment.
@adwk67 I tested this using Helm 4.1.1 on NixOS. I transformed the .j2 template into a YAML file and ran commands like this:
/tmp/helm411/linux-amd64/helm template minio --version 12.6.4 -f helm-bitnami-minio-values.yaml --repo https://charts.bitnami.com/bitnami minio | grep -C2 BITNAMI_DEBUGI noticed two things:
- Helm 4 does not error out for me when
BITNAMI_DEBUGis set inextraEnvVars - When we remove
BITNAMI_DEBUGhere the value is set tofalse(wastruebefore), is that intended?
Member
Author
If I recall, we had some challenges 2+ years ago in getting minio to work for our tests on Openshift, as there are/were 2 different charts, both of which were broken in different ways. I think turning on the debug setting was done in that context, and was never removed. I don't see any reason to have that turned on by default (we could probably remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove duplicate env-vars that showed a warning with Helm 3 but throw an error with version 4.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker